Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return integer|false from parse_bytes() function #9271

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Return integer|false from parse_bytes() function #9271

merged 6 commits into from
Dec 18, 2023

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 17, 2023 •
edited
Loading

Bytes are discrete, however 2.5MiB decimal value should still be accepted, at least for BC.

@mvorisek mvorisek marked this pull request as draft December 17, 2023 13:49
@mvorisek mvorisek marked this pull request as ready for review December 17, 2023 13:50
@mvorisek mvorisek changed the title Return integer from parse_bytes() function Return integer|false from parse_bytes() function Dec 17, 2023
@mvorisek mvorisek force-pushed the parse_bytes_integer branch from 0f698ff to 629fe4a Compare December 17, 2023 14:28
@alecpl
Copy link
Member

alecpl commented Dec 17, 2023

I just added convertDeprecationsToExceptions="true" in master. I suppose the null case will throw a deprecation warning.

@mvorisek mvorisek marked this pull request as draft December 17, 2023 15:26
@mvorisek mvorisek force-pushed the parse_bytes_integer branch from 1841879 to d3f05aa Compare December 17, 2023 15:48
@mvorisek mvorisek marked this pull request as ready for review December 17, 2023 20:44
@alecpl alecpl merged commit aa3803e into roundcube:master Dec 18, 2023
15 checks passed
@mvorisek mvorisek deleted the parse_bytes_integer branch December 18, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @alecpl